-
-
Couldn't load subscription status.
- Fork 50
v2.9.0 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
v2.9.0 #431
Conversation
Signed-off-by: Michał Górny <[email protected]>
Fixes conda-forge#420 Signed-off-by: Michał Górny <[email protected]>
…5.10.23.10.43.38 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9
During debugging, can you please reduce the number of builds to ~one python version? Or maybe one+3.14 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18886564008. Examine the logs at this URL for more detail. |
Sure. Could you stop the Azure builds then? |
Signed-off-by: Michał Górny <[email protected]>
Azure is much less critical for resource scarcity, but if you want sure. Easiest is to just push a skip though |
|
I'll also strip down CUDA targets. |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
…5.10.23.10.43.38 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9 Signed-off-by: Michał Górny <[email protected]>
|
(mumbling about platform-conditional patching) |
Signed-off-by: Michał Górny <[email protected]>
|
I have an updated patch ready, but will wait for other jobs to finish. |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
…5.10.23.15.25.29 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9 Signed-off-by: Michał Górny <[email protected]>
|
Looks like it's not ready for py3.14 yet. I'm going to look for another solutions for triton later today. |
|
Okay, so:
|
Signed-off-by: Michał Górny <[email protected]>
…5.10.24.23.37.09 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9 Signed-off-by: Michał Górny <[email protected]>
|
I suppose we're making some progress:
|
Signed-off-by: Michał Górny <[email protected]>
I'm going to try if setting
pytorch/pytorch#164139 so an upstream regression, I guess. |
Signed-off-by: Michał Górny <[email protected]>
Yep, looks like it isn't being built at all anymore, on Windows (on Linux it seems to be). So now the question is: is this an upstream change, or a regression on our end? And if the former, do we want to follow or change it back? |
The code checks for |
Signed-off-by: Michał Górny <[email protected]>
So the command used in tests is: which is missing the |
Signed-off-by: Michał Górny <[email protected]>
| + python_include_dirs | ||
| + torch_include_dirs | ||
| + omp_include_dir_paths | ||
| + + [sys.prefix + '/include'] | ||
| + + [sys.prefix + '/targets/@CUDA_TARGET@/include'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, I'm aware that the path is left here with literal @CUDA_TARGET@ on Windows/non-CUDA builds. I've figured out it won't harm and should keep the patch simpler.
|
Uh, so it looks like FBGEMM fails to build on Windows now? |
|
Looks like neither AArch64 fix helped with the assert, not the libfmt patch helped with installing the headers. Maybe at least CUDA path patch helped… |
|
Okay, that libfmt error is kinda our problem. but we copy some of the headers into the top
|
My preference would be to try 1. (especially since they seem to have migrated to fmt 12 already; needs inclusion of the respective migrator here), but to limit how much effort we put into this. Basically, as soon as using the native fmt fails in some non-trivial way, go back to vendored fmt (and patch the include paths to use the vendored version) |
|
Le sigh, looks like more CUDA work needed: I really do wonder why it didn't fail before. |
This reverts commit 29b1abe. FBGEMM doesn't build on Windows anymore. Signed-off-by: Michał Górny <[email protected]>
This reverts commit 550e5c3. We'll try system libfmt instead. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
…5.10.28.08.08.15 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9 Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
|
I'd use some Windows hints here: Is this something to add in our test But that kinda implies all downstream projects will have to do it as well. Not sure if it also happens when using vendored libfmt, but I guess so. |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #430. Added py3.14 migration too, let's see how it goes.